Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/add application codes to all memos #168

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Feat/add application codes to all memos #168

wants to merge 10 commits into from

Conversation

Rao-Sabahat-Ali
Copy link
Contributor

  1. Added new get requests to get all memos and memofiles from both coursememos and memofiles collections.
  2. Added new Put service to update application codes in both coursememos and memofiles collections.

Note: Please do not merge this PR. It is only for review to update both collections with application codes.

lenaar
lenaar suggested changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@lenaar lenaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It look like one parameter if off if to compare with prev code, should be checked, otherwise looks good to me. Ready to be tested on all test data

swagger.json Outdated
"type": "string"
},
{
"name": "status",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this status is a duplicate of the one on line 289

server/lib/dbSeveralDocument.js Outdated
await webBasedMemos.map(({ ladokRoundIds }) => finalObj.usedRoundsThisSemester.push(...ladokRoundIds))
await dbMigratedPdfs.map(({ koppsRoundId }) => finalObj.usedRoundsThisSemester.push(...koppsRoundId))
await webBasedMemos.map(({ applicationCodes }) => finalObj.usedRoundsThisSemester.push(...applicationCodes))
await dbMigratedPdfs.map(({ applicationCodes }) => finalObj.usedRoundsThisSemester.push(...applicationCodes))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here it looks like it should destruct dbMigratedPdfs applicationCode (singular) if to compare with prev code

lenaar
lenaar reviewed Feb 8, 2023
View reviewed changes
Copy link
Contributor

@lenaar lenaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One parameter seems is off, should be checked before running on test data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenaar lenaar lenaar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rao-Sabahat-Ali @lenaar @4886Talga